Open
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
🛡️ The following IaC misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| JSON '$ref' alongside other properties | ...st/schema.check.json | View in code | |
| Empty Array | .../rest/schema.v3.yaml | View in code | |
| ... | ... | ... | ... |
🛡️ The following SAST misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
| Leaky Use of time.After in for-select Statements | backup/wait.go | View in code |
Note: The scan should have failed if no policies were configured in warn-only mode.
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Secrets | View in Orca |
tsmith023
reviewed
Mar 13, 2026
tsmith023
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Backup API with support for all features from v1.36 (cancel restore, incremental backups) and previous releases.
Key changes:
backup/client.go- new namespaced client, i.e. the public APIinternal/api/backup.go- implementation of the supported REST requestsbackup/wait.go- AwaitSuccess and AwaitStatus utilsbackup/client_test.go,backup/wait_test.go,internal/api/endpoint_test.go-- unit testsMiscellaneous:
internal/testkit/context.go- adds "ticking context", which expires after Done has been called a certain number of times. Useful for mocking context timeouts at fine granularity.ErrorIsininternal/testkit/error.gois similar to theExpectErrorbut allows asserting specific a concrete error type.